This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
kubeaudit
on the cli, we generally yield an exit code other than 0 if the report contains errors.However, when we run it with the sarif format, we get 0 even when we have errors. This happens, because we're returning
here to avoid printing extra info to the console. This means we never reach this line.
Fixes #575
Type of change
How Has This Been Tested?
use one of the manifest files in the repo to test. Example:
auditors/privileged/fixtures/privileged-nil.yml
go run ./cmd/main.go all -f auditors/privileged/fixtures/privileged-nil.yml --format=sarif
when you run
echo $?
you should see2
Checklist: