-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breeding #7110
Open
Efnilite
wants to merge
67
commits into
SkriptLang:dev/feature
Choose a base branch
from
Efnilite:breeding
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add breeding #7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a437ca9.
📎 Added EntityEnterLoveModeEvent 🐷 Added EntityBreedEvent ✨ Added EventValues for these events
👪 Added family expression for Father, Mother, Child, and Breeder ✨ Added breeding experience to experience class *update class to current standards
✨ Added condition for checking ageable ✨ Added condition for checking breedable ✨ Added effect for toggle breedable ✨ Added effect for locking age ✨ Added expression for love ticks
🐛 Fixed issue with `livingentities` 🐛 Added class exist checks for Breedable instances ✨ Added RequirePlugins annotation to select classes
📋 Added test for ExprLoveTime & CondIsInLove 📋 Addes test for EffBreedable & CondCanBreed 📋 Added test fpr EffLockAge & CondCanAge
✨ Added Condition for checking is adult ✨ Added Effect to make an entity a baby or adult 📋 Added test for these syntaxes 🔵 1.16 for any mob, below that is animals only
Thanks for all these formatting changes it's just what I wanted when waking up Co-authored-by: Ayham Al Ali <[email protected]>
✨ Renamed expression to ExprLoveTicks ✨ Added support for ticks via integers 📋 Added a new test for using integers 📋 Removed unneeded test condition
✨ Changed expression for father, mother and offspring a bit ✨ Converted get to a switch statement
🐛 Fixed an issue where set allowed more than one value 🐛 Fixed a typo in examples ✨ Added a spacer to examples
Co-Authored-By: Ayham Al Ali <[email protected]>
Just adds some notes in descriptions to bring more light to animal exclusive syntax Co-Authored-By: Ayham Al Ali <[email protected]>
🐛 fix accidental forgotten example 🔴 remove integer support from love ticks expression 📋 remove a test from CondIsInLove.sk Co-Authored-By: Ayham Al Ali <[email protected]>
🐛 Fixed an issue with ExprLoveTicks not working correctly 📋 Updated test to include more checks for add, remove and reset
Co-Authored-By: Ayham Al Ali <[email protected]>
Co-authored-by: LimeGlass <[email protected]>
Co-authored-by: LimeGlass <[email protected]>
Co-authored-by: LimeGlass <[email protected]>
…kript-forky into enhancement/Breedable
Efnilite
requested review from
Asleeepp and
sovdeeth
and removed request for
Asleeepp
September 23, 2024 21:04
sovdeeth
requested changes
Sep 26, 2024
@Examples({ | ||
"on right click on living entity:", | ||
"\tevent-entity can't breed", | ||
"\tsend \"Turns out %event-entity% is not breedable. Must be a Skript user!\" to player" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💀
sovdeeth
approved these changes
Sep 26, 2024
Efnilite
commented
Oct 17, 2024
.description("Called whenever an entity enters a state of being in love.") | ||
.examples( | ||
"on love mode enter:", | ||
"\tcancel event # No one is allowed love here" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #5584. Reverts the breaking change in ExprExperience in the previous PR.
Thanks @Fusezion!
Target Minecraft Versions: any
Requirements: none
Related Issues: #5111