Slight Exception message changes #7116
Conversation
sovdeeth
added
the
enhancement
| String issuesUrl = "https://github.com/SkriptLang/Skript/issues"; | ||
| String downloadUrl = "https://github.com/SkriptLang/Skript/releases/latest"; |
There was a problem hiding this comment.
It might be better to grab this from the update checker
Though I don't think the update checker currently records this for GitHub, so a TODO comment would suffice for now
There was a problem hiding this comment.
Wouldn't using releases/latest (like it is currently) suffice for this? I don't see the difference it would make.
There was a problem hiding this comment.
I just mean that the update checker might not always point to GitHub (e.g. in the future it could recommend Spigot if that's where you downloaded Skript from)
| pluginPackages.entrySet().stream() | ||
| .filter(entry -> element.getClassName().startsWith(entry.getKey())) | ||
| .forEach(entry -> stackPlugins.add(entry.getValue())); |
There was a problem hiding this comment.
You could just compile a set of plugins based on which ones provided the classes using https://hub.spigotmc.org/javadocs/spigot/org/bukkit/plugin/java/JavaPlugin.html#getProvidingPlugin(java.lang.Class)
Though that would require obtaining a Class instance, which might be a little heavy, but it is certainly worth trying IMO
| logEx(); | ||
| } | ||
|
|
||
| private static String getStatusDescription(ReleaseStatus status) { |
There was a problem hiding this comment.
It might be worth integrating this into the ReleaseStatus enum
Description
Honestly, I'm not really the biggest fan of how the exception is laid out, especially lines 1759-1763, and the constant "You'll be given instructions on how to report this", but I'd rather not change that.
This PR aims to fix some punctation errors I found, and also reword some sentences.
Target Minecraft Versions: any
Requirements: none
Related Issues: none