-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod Material support, for Hybrid Server #7126
base: dev/patch
Are you sure you want to change the base?
Conversation
(ref: #7121 (comment))
(ref: #7121) good job! your unrealized plan in the previous PR was finally realized, while ensuring the core functions of Skript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
i just did some tests, no worry, all of them are runned as expected:
this is an epic PR for me, thanks! this is why i love Skript's community. |
|
Just like |
I'd like |
Actually idk what is it, but there was a |
ignore that message, it's fine to have |
I'm a bit concerned on how many aliases this will add if it's 3 per modded item, skript already suffers enough from how many they just add. |
one point: they are not generated for everyone. with this PR, it will just create aliases for things that ALREADY in your server. if you don't have mod items (like vanilla server), it won't affect you at all. |
Not |
well it's 4 per item, vs 2 per item for the vanilla items |
here is what this PR do:
in future, maybe Mojang will provide a way to let creators add blocks/items/etc. to Minecraft by simply using datapakcs (like Bedrock Edition's behavior pack + resource pack), then creators could use their own nameplaces (not |
And this will be made less bad by #7084 :) |
Thank but I'm aware I know what this PR does and I'm aware what I said
Must of missed something, thought it was 3. I never said we should scrap this whole thing just because of that.
Wait wait it's 4 now? And no it really isn't cheap for 40k that's still a major concern granted it should be rare for anyone to reach 10k items, so I'm fine with stepping down on this but none the less it's concerning. If anything a config option should still be added similar to vanilla minecraft items but only accept namespace key path and remove |
40k is very cheap for 10k items, honestly. The benefit from having basic grammatical aliases far outweighs the slight reduction in alias count, imo.
There is no such config option for vanilla items that does that, though. and RE: the 233k current ones, those will not be included by default in 2.10, only the ~4000 auto generated ones for the ~2000 items minecraft has |
idk if there is a need to add a config option as @Fusezion said, but i could post my server log for reference:
my server has 260000+ aliases and it loaded for 8747ms. |
I don't see a need for a config option, but I do want to ask whether we should add a warning when running on a modded server? We don't support modded platforms, so it is probably not a good idea for people to be using skript to build their modded servers. I know people will do it anyway, but I'd love to at least make it clear they are on their own. |
i don't think there is a need to add warnings... because it doesn't affect vanilla server at all. btw,
this is not a thing only about modded platforms. i could use my reply above:
|
I feel like we should, because some modded platforms mess with some internal code so yeah, and plus if people go to open an issue about it, they may see that yellow warning message and not do it |
I'm neutral. It doesn't matter if we warn them or not. |
I am in favor of this pull request. While it's true that Skript doesn't officially support Hybrid servers, a significant number of users still use it with Hybrid servers. Therefore, I believe it's highly beneficial to merge this. |
currently it doesn't support mod's entity type, maybe it will be better if this PR makes Skript support mod entities, just like using the command below to summon a mod entity:
thank you for bringing this epic PR! |
That's out of scope for this PR, and probably out of scope in general for skript at the current moment, since it would involve adding entitydatas. |
not planned now |
Description
As title, support for items which added by mods
For PR: #7121
①
②
It's an old screenshot. Now it's
quack's abacus
The pattern just like:
mod:an_item_name_with_line
(parsed to alias)→mod's an item name with line
And vanilla aliases are not changed.
minecraft:dirt
→dirt
Target Minecraft Versions: any
Requirements: none
Related Issues: #4051 #4678 #4778 #6503