Minecraft Tags #7127
Open
Minecraft Tags #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusezion
suggested changes
Oct 3, 2024
src/main/java/org/skriptlang/skript/bukkit/tags/CondIsTagged.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/ExprTagContents.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/ExprTagContents.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/ExprTagContents.java
Outdated
Show resolved
Hide resolved
Fusezion
reviewed
Oct 3, 2024
src/main/java/org/skriptlang/skript/bukkit/tags/CondIsTagged.java
Outdated
Show resolved
Hide resolved
paper's material/entity tags, get all tags of something
… into feature/block-tags
Tests are kept deliberately small due to the volatile nature of tag contents.
sovdeeth
requested review from
APickledWalrus,
Romitou,
Efnilite,
Pesekjak,
cheeezburga,
erenkarakal,
TenFont and
UnderscoreTud
and removed request for
Fusezion
erenkarakal
approved these changes
Oct 4, 2024
ShaneBeee
reviewed
Oct 4, 2024
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
Efnilite
suggested changes
Oct 5, 2024
src/main/java/org/skriptlang/skript/bukkit/tags/elements/CondIsTagged.java
Outdated
Show resolved
Hide resolved
TheLimeGlass
requested changes
Oct 9, 2024
Comment on lines
+57
to
+62
| return "tag \"" + tag.getKey() + "\""; | ||
| } | ||
|
|
||
| @Override | ||
| public String toVariableNameString(Tag<?> tag) { | ||
| return "tag: " + tag.getKey(); |
There was a problem hiding this comment.
Why can't the variable name and the string printed to string be the same output? Users will end up using a string for comparison by setting a variable to a string to be displayed in a way, and then use that same string for comparison.
Same issue was seen with itemtypes back in the day.
#4930
#1554
#913
Blueeyescat would find these alot https://github.com/SkriptLang/Skript/issues?q=is%3Aissue+author%3ABlueyescat
There was a problem hiding this comment.
I didn't think having quotes in an index would be very nice. Do you think that's a concern?
| * Gets all the tags of a specific origin that are of a specific type. | ||
| * @param origin The origin to filter by. | ||
| * @param type The type of tags to get. | ||
| * @return Tags from the given origin that are of the given type. |
There was a problem hiding this comment.
Suggested change
| * @return Tags from the given origin that are of the given type. | |
| * @return Iterable<Tag<T>> tags from the given origin that are of the given type. |
There was a problem hiding this comment.
What's the point of this? The return type is already part of the method signature, and this doesn't do anything special for javadocs.
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTagKey.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTagsOf.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTag.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTagsOfType.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/tags/elements/ExprTagsOfType.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for minecraft's tag system.
Currently supports block, item, and entity type tags. Fluid and GameEvent are simple to add, but Fluid is useless and GameEvent is not in Skript just yet.
paper:name_settagnaturally. This converts them so the user sees and usespaper:name.paper tag "wooden_doors"to resolve topaper:wooden_doors.Target Minecraft Versions: any
Requirements: none
Related Issues: #4924