Add experience point support to ExprTotalExperience #7144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
added
the
enhancement
Efnilite
suggested changes
Oct 13, 2024
| } | ||
|
|
||
| @Override | ||
| @Nullable | ||
| public Integer convert(Entity entity) { | ||
| public Integer convert(Object object) { |
There was a problem hiding this comment.
Suggested change
| public Integer convert(Object object) { | |
| public @Nullable Integer convert(Object object) { |
|
|
||
| // invalid entity type | ||
| // invalid type | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| @Nullable | ||
| public Class<?>[] acceptChange(ChangeMode mode) { |
There was a problem hiding this comment.
Suggested change
| public Class<?>[] acceptChange(ChangeMode mode) { | |
| public Class<?> @Nullable [] acceptChange(ChangeMode mode) { |
| return null; | ||
| } | ||
| return switch (mode) { | ||
| case ADD, REMOVE, SET, DELETE, RESET -> new Class[]{Number.class}; |
sovdeeth
approved these changes
Oct 13, 2024
Comment on lines
+66
to
+72
| if (object instanceof Player player) | ||
| return PlayerUtils.getTotalXP(player.getLevel(), player.getExp()); | ||
|
|
||
| // experience points | ||
| if (object instanceof Experience experience) { | ||
| return experience.getXP(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 'experience point' support to the total experience expression and some tests.
The reason I made this PR is for the "on level progress change:" event. It did not let you get how much experience was changed as a number.
Target Minecraft Versions: any
Requirements: none
Related Issues: none