Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ensure language combobox shows default language #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Jan 16, 2024

This change ensures the fix integrated through commontk/CTK#1179 (BUG: Fix ctkLanguageComboBox normalizing default language and selection) is effective.

After installing the extension without having selected any language (and a settings file without any language entry or an empty one):

Before After
image image

References:

This change ensures the fix integrated through commontk/CTK#1179 (BUG: Fix
ctkLanguageComboBox normalizing default language and selection) is effective.
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lassoan?

@lassoan
Copy link
Collaborator

lassoan commented Feb 28, 2024

The issue description suggests that it is wrong to display an empty selection when the current application language is not selected. For me, the current behavior seems correct, as it is important to distinguish between the user selected "English (US)" / the user did not specify any language. For example, if no language is explicitly selected then in the future we could automatically use the operating system's language.

@lassoan
Copy link
Collaborator

lassoan commented Feb 28, 2024

Maybe a good solution could be to have an explicit automatic option. If the user selects that then language would be set to empty string in the application settings. This automatic language option could appear in the combobox as (automatic) or automatic - English (US). When we implement automatic language selection based on OS language then we could always display the actual OS language instead of hardcoding - English (US).

@pieper
Copy link
Member

pieper commented Feb 28, 2024

Yes, automatically using the OS setting makes a lot of sense and making this explicit in the combo box would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants