ENH: Enable reset simulations #23
Conversation
There was a problem hiding this comment.
@Quilliams85, thanks for the contribution. In general, this goes in the right direction. I think we can improve the re-usability of the code and its generalization. For that I proposed a couple of changes.
| if self._sceneUp is False or self._simulationRunning is False: | ||
| slicer.util.errorDisplay("Can't advance the simulation forward. Simulation is not running.") | ||
| return | ||
|
|
||
| parameterNode.modelNode.GetUnstructuredGrid() |
There was a problem hiding this comment.
This is not needed, we should remove it
| def resetSimulation(self, parameterNode=None) -> None: | ||
| pass | ||
|
|
There was a problem hiding this comment.
This function has little use as is. I would move here all the lines involving member variables of this class from https://github.com/Quilliams85/Slicer-SOFA/blob/7bbc2cea19222da2e40646b99230668d78d0bfa9/SoftTissueSimulation/SoftTissueSimulation.py#L406-L417
| self._dt = 0 | ||
| self.initialgrid = [] |
There was a problem hiding this comment.
For now I would leave this to the derived classes. Two reasons:
- Not all simulations necessarily will deal with unstructured grids (some may use surface meshes as polydata)
- Some simulations may imply the use and update of more than one model.
| points_vtk = numpy_to_vtk(num_array=self.initialgrid, deep=True, array_type=vtk.VTK_FLOAT) | ||
| vtk_points = vtk.vtkPoints() | ||
| vtk_points.SetData(points_vtk) | ||
| self.getParameterNode().modelNode.GetUnstructuredGrid().SetPoints(vtk_points) |
There was a problem hiding this comment.
@pieper recommended to not to use this way of updating the mesh as the ownership of the underlying memory by sofa objects and vtk objects can cause this to crash. Instead, you can look at https://github.com/RafaelPalomar/SlicerSOFA/blob/ce4b4131a9ed4a0403641de4cf44efcf455d2c34/MultiMaterialSimulation/MultiMaterialSimulation.py#L289-L298 where I use the approach suggested by @pieper
As mentioned above, moving as much as possible to the base class will help reusing the code
Added ui button and logic to reset the deformations on a model from a simulation for the soft-tissue-simulation module. Also fixed the time step counter so that it updates the UI each step.