Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Enable clippy::same_name_method lint #1556

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP Enable clippy::same_name_method lint #1556

wants to merge 1 commit into from
+5 −3

Commits on Oct 2, 2024

  1. WIP Enable clippy::same_name_method lint 

    It is confusing and error prone to have a method on a type and a trait
implemented by that type with the same name.

This is particularly bad for something like `<Window as SpaceElement>::bbox`,
which actually calls `Window::bbox_with_popups`. Which is different from
`Window::box`. But these three functions have the same type signature.

It seems good to disallow this lint in general, but it can be allowed
where the methods do the same thing.
    @ids1024
    ids1024 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f14a397 View commit details
    Browse the repository at this point in the history