wayland.pointer_constraints: Remove constraints in the destructor #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
approved these changes
Oct 25, 2024
|
CI doesn't seem to be happy |
PolyMeilex
force-pushed
the
constraints-destructor
branch
from
dc2645d
to
6f7ae38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this works fine as is, but just to be 100% sure that the reference cycle (see #1552) gets broken properly, let's remove the constraint in the destructor rather than on event.
remove_constraintremoves the constraint object fromwlsurfaceuser data, and as the constraint object contains the surface in its own user data this makes sure that the cycle is broken properly.