Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #38 - support rust_decimal. #42

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix #38 - support rust_decimal. #42

wants to merge 9 commits into from

Conversation

finnbear
Copy link
Member

Fixes #38

@finnbear finnbear mentioned this pull request Sep 20, 2024
Merged
@finnbear
Copy link
Member Author

finnbear commented Sep 23, 2024 •
edited
Loading

Remaining questions:

  • Is the Flags encoding maximally efficient?
    • justification of why it is: putting the sign bit at the LSB could help reduce the overall range of u8 values, allowing packing to work
  • Do all numbers round-trip properly?
    • need to check non-normalized decimal (with trailing zeroes)
    • strongly suspect -0 would be converted to 0 upon decoding (I want to fix this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for rust_decimal
1 participant
@finnbear