Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix templating of cluster-addon-values.yaml #130

Merged
merged 2 commits into from
May 30, 2024

Conversation

chess-knight
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #116

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@cluster-stack-bot cluster-stack-bot bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/code Changes made in the code directory labels May 30, 2024
Copy link
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Just to understand: The templating has been done anyway in the .tmp folder, so all we have to do is copying the file not from the original folder but the temporary one?!

@chess-knight
Copy link
Member Author

Just to understand: The templating has been done anyway in the .tmp folder, so all we have to do is copying the file not from the original folder but the temporary one?!

Exactly

@janiskemper janiskemper merged commit 98772be into main May 30, 2024
5 checks passed
@janiskemper janiskemper deleted the fix/template-cluster-addon-values branch May 30, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster-addon-values are not templated
2 participants