✨ Support calling provider plugins. #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cluster-stack-bot
bot
added
size/S
guettli
force-pushed
the
tg/call-csmplugin
branch
from
5b5fb1e
to
491378b
Compare
Signed-off-by: Thomas Guettler <[email protected]>
guettli
force-pushed
the
tg/call-csmplugin
branch
from
491378b
to
b47f913
Compare
janiskemper
requested changes
Jan 24, 2024
jschoone
added
the
Container
|
@guettli can you rebase this today and fix linting etc.? Then we can merge it. I think it is tested already and we need to continue working on this with other PRs that require this one here |
|
Sad, that we did not merge this PR earlier. There were a lot of conflicts with the main branch now. I created a new PR: #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OLD
Sad, that we did not merge this PR earlier. There were a lot of conflicts with the main branch now. I created a new PR: #97
What this PR does / why we need it:
We need a way to call csmctl plugins which handle the provider specific parts (like creating node-images).
Which issue(s) this PR fixes
Fixes #4
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: