Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 pin go-github dependency to v56 #65

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

kranurag7
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@janiskemper
Copy link
Member

is this helping if csmctl tries to update to v58?

@kranurag7
Copy link
Contributor Author

is this helping if csmctl tries to update to v58?

Yes, pinning helps. But we also have to remember to update renovate config when we update to v58 manually.

@kranurag7 kranurag7 marked this pull request as ready for review February 2, 2024 10:00
@cluster-stack-bot cluster-stack-bot bot added the area/github Changes made in the github directory label Feb 2, 2024
@kranurag7 kranurag7 merged commit 5eaa92a into main Feb 2, 2024
3 checks passed
@kranurag7 kranurag7 deleted the syself/pin-go-github branch February 2, 2024 10:03
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github Changes made in the github directory Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants