Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only debug output the public/community images. #762

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

garloff
Copy link
Contributor

@garloff garloff commented Sep 25, 2024

This avoids confusion by seeing images that are private. Like in the mandatory image test, this can be overriden with -p/--private.

This avoids confusion by seeing images that are private.
Like in the mandatory image test, this can be overriden with
-p/--private.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff added enhancement New feature or request standards Issues / ADR / pull requests relevant for standardization & certification labels Sep 25, 2024
@garloff garloff self-assigned this Sep 25, 2024
@garloff
Copy link
Contributor Author

garloff commented Sep 25, 2024

I had images like EVIL registered to test vulnerabilities in my environment.
When I saw the compliance test suite reporting their existence I also expected that I would fail, as these do not have the necessary metadata ...
It did not ... in the end the tool listing all images was the one that looked for mandatory standard images.
The tool looking for metadata does disregard private images by default.
So let's align the behavior: Let's look only at "community" and "public" images in both tools by default and let's support -p and --private in both tools to override this restriction.

Copy link
Contributor

@mbuechse mbuechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to do #766 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants