Feat/add blog rookify #1012
Open
Feat/add blog rookify #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boekhorstb1
force-pushed
the
feat/add-blog-rookify-rook
branch
3 times, most recently
from
461d85f
to
b1ed562
Compare
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
…ookify Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
…g links Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
… also add more information about the algorithms for migrating mds and osds Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
fkr
force-pushed
the
feat/add-blog-rookify-rook
branch
from
b1ed562
to
d4309b1
Compare
fkr
commented
Sep 5, 2024
fkr
commented
Sep 5, 2024
fkr
commented
Sep 5, 2024
fkr
commented
Sep 5, 2024
fkr
commented
Sep 5, 2024
There was a problem hiding this comment.
@boekhorstb1 Very cool articles.
Couple suggestions:
- Let's move these into two PRs: one for the rook posts, one for the rookify posts
- Update the dates (for example tomorrow and monday)
- Let's get someone else to give it a final review, but they do LGTM.
Co-authored-by: Felix Kronlage-Dammers <[email protected]> Signed-off-by: boekhorstb1 <[email protected]>
Co-authored-by: Felix Kronlage-Dammers <[email protected]> Signed-off-by: boekhorstb1 <[email protected]>
Co-authored-by: Felix Kronlage-Dammers <[email protected]> Signed-off-by: boekhorstb1 <[email protected]>
Co-authored-by: Felix Kronlage-Dammers <[email protected]> Signed-off-by: boekhorstb1 <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
boekhorstb1
force-pushed
the
feat/add-blog-rookify-rook
branch
from
ed1f764
to
120793a
Compare
|
@NotTheEvilOne I added you as reviewer, as Felix suggested to have one more approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.