Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of private apps data #200

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lifeismana
Copy link
Contributor

@Lifeismana Lifeismana commented Oct 17, 2024

Moved fetching the store token to its own function to dedup but i'm not sure if storing it in local storage should be kept, do we trust users enough to not get it stolen?

I've tested FetchPrivateApps but not SetAppPrivate

I haven't gated this behind an option since, depending of what's made of this, the fetch would fit under "Enable extra filtering on sales page and bundles page" and the set under "Wishlist, follow, and ignore products on the Steam store directly from SteamDB"

@xPaw
Copy link
Member

xPaw commented Oct 17, 2024

I don't want the highlighting to be too overloaded (especially with extra requests), and I'm not entirely sure there's much value for knowing private apps on steamdb site.

@Lifeismana
Copy link
Contributor Author

I also think that highlighting them isn't that useful (that fetchPrivateApps is probably not placed well in regard to that)
the only value i really see is show every private app in 1 place since it's not something that Steam does, maybe with a new filter "show only private apps" here https://steamdb.info/sales/?displayOnly=OwnedGames (although also having that filter under the default sale page might be weird)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants