Create DebtFilter module for Bet #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luukveenis
requested changes
Mar 22, 2017
| reverse_negatives(merge_debts(reverse_duplicates(debts))) | ||
| end | ||
|
|
||
| def unique_participants(debts) |
There was a problem hiding this comment.
This whole method can be written in a much simpler way.
Hint: Think about the fact that you're creating an array called uniques and ensuring uniqueness of the things you're adding to it.
| @@ -0,0 +1,55 @@ | |||
| module DebtFilter | |||
There was a problem hiding this comment.
This module has one public method, but 5 private methods that handle combining debts between the same people. These methods also iterate over the same array many times, maybe see if you can simplify this.
|
This branch is out of date with master. Please update. |
-DebtFilter addresses the problem, where some of the created Debts for a particular Bet would cross-reference each other (PersonA -$50-> PersonB && PersonB -$20-> PersonA) or accumulate as separate entries (PerosnA -$50-> PersonB && PersonA -$20-> PersonB) by filtering them before saving. -Added DebtFilter to Bet model. Debts are now filtered before getting saved.
ghost
force-pushed
the
removing_duplicates_from_resolved_bet
branch
from
371eb98
to
ec4c39c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal: https://www.pivotaltracker.com/story/show/141907091
-DebtFilter addresses the problem, where some of the created Debts for a
particular Bet would cross-reference each other (PersonA -$50-> PersonB
&& PersonB -$20-> PersonA) or accumulate as separate entries (PerosnA
-$50-> PersonB && PersonA -$20-> PersonB) by filtering them before
saving.
-Added DebtFilter to Bet model. Debts are now filtered before getting
saved.