This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Add AthenaClient.webview.off Function #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let us override AthenaClient.webview.on functions. Just had the problem that i searched for hours why my Plugin keeps using an old value until i found out that the ClientEvents get cached. Maybe there is another better work around than this pull if yes please lmk and close it.
MnkyArts
changed the title
MnkyArts
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets us override AthenaClient.webview.on events.Just had the problem that i searched for hours why my Plugin keeps using an old value until i found out that the ClientEvents gets cached.
Maybe there is another better work around than this pull if yes please lmk and close it.Scraped the whole override idea after talking with @jonasesser. We added now a .off function to remove an ClientEvent.