Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yeast 8.5.0 #260

Closed
wants to merge 67 commits into from
Closed

yeast 8.5.0 #260

wants to merge 67 commits into from

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jul 1, 2021

Main improvements in this PR:

Also rename your local branches to main and develop:

git branch -m master main
git branch -m devel develop
git fetch origin
git branch -u origin/main main
git branch -u origin/develop develop
git remote set-head origin -a

PR #261 should first be merged

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected main as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

mihai-sysbio and others added 23 commits April 11, 2021 14:18
- eccodes and rxnConfidenceScores are not under 'annotation'
- empty references and subsystems should not be written
- generated with RAVEN after commit 99a4536b94b07968a7bbebfb39922c76be7f4e1a
- run model=rmfield(model,'subSystems') before running saveYeastModel, until subSystems are added (see #11)
This partially reverts commit 919d396.
Restores the model.id so it will not have the dash (so yeastGEM instead of yeast-GEM)
mistakingly reverted in last commit
Benjamin's email no longer active, replace with Eduard's
@edkerk edkerk closed this Jul 1, 2021
@edkerk edkerk deleted the devel branch July 1, 2021 13:53
@mihai-sysbio
Copy link
Member

It should be possible to just change the target branch in this PR without opening a new one?

@mihai-sysbio
Copy link
Member

Also, is the intention to resolve #11 as part of this release, or would it be better to postpone it?

@edkerk
Copy link
Member Author

edkerk commented Jul 1, 2021

I didn't close it manually, but I did just change the name of devel to develop, in accordance with #258. It might be that GitHub is at the moment still processing the name change, and will reopen it soon again to the newly named branch.

Re #11, this would take longer to resolve, so probably good to postpone to distribute as 2.5.1?

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Jul 1, 2021

Oh, interesting side-effect of branch renaming.
Sure, it's okay reserve #11 for a subsequent release.

@edkerk
Copy link
Member Author

edkerk commented Jul 1, 2021

Here is mentioned:

After the rename is complete, GitHub provides instructions on the repository's home page directing contributors to update their local Git environments.

Considering this is not showing on the home page yet, I assume they haven't finished the procedure yet. If this is not resolved by tomorrow I'll manually fix this PR.

This seems to be referring to changing name of the default branch, not other branches. Because the "from" branch is renamed, the source is missing and seems like I'll have to remake the PR. Now done as #262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants