Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependabot config #267

Merged
merged 4 commits into from
Aug 24, 2021
Merged

fix: dependabot config #267

merged 4 commits into from
Aug 24, 2021

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Aug 24, 2021

Main improvements in this PR:

  • fix:
    • dependabot makes monthly (if required) PR to develop instead of main
  • chore:
    • also store gh-pages memote release workflow configuration in develop (was already in main: e778a36)

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected develop as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@mihai-sysbio
Copy link
Member

It's unexpected that a file would end up in main without going through develop so it'a good to address that.
But about the release workflow, how is that different from the other workflow in terms of purpose?

@edkerk
Copy link
Member Author

edkerk commented Aug 24, 2021

Ah sorry, it is the workflow that makes gh-pages, I should have clarified that. And it should only run when a new version is released, will fix that in commit below.

Copy link
Contributor

@BenjaSanchez BenjaSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@edkerk edkerk merged commit c5014e7 into develop Aug 24, 2021
@edkerk edkerk deleted the fix/GitHub_settings branch August 24, 2021 13:31
@mihai-sysbio
Copy link
Member

I'm sorry this comes in a bit late, but I'm really confused and had not the chance to get back to this earlier.
What I can't figure out is the difference between the new memote_release and the previous memote-history workflows. In fact, it looks to me like the memote_release workflow overwrites what memote-history does, which is only fueling my confusing. What am I missing here?

@edkerk
Copy link
Member Author

edkerk commented Aug 27, 2021

  • memote-history runs with each push, and is therefore run with each PR to show the current status. It stores a history report in history_report.html (although it is empty, but we agreed to have the workflow merged anyway).
  • memote_release runs with each release, which happens much more sporadic, and rather represents the status of the latest release version, not the latest devel version. It stores a snapshot report in release_report.html, which the gh-pages (https://sysbiochalmers.github.io/yeast-GEM/) links to (although the meaning of the memote report should probably be explained in 1-2 lines).

So while both run memote, they make different reports, stored in different locations, run at different triggers. Can one leave comments in a workflow yml file? Might be good to have the intention documented within the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants