[TASK] Catch errors in schema generation and collect them #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the method exits hard on error with an exception with no way to recover. Additionally, the TYPO3 command "fluid:schema:generate" can now display the errors occured.
|
See also: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86360 for the consuming TYPO3 command. |
|
Without the patch and adjusting the TYPO3 command the following exception is given on the first error rising (for EXT:schema): The abstract view helpers uses a constructor which is not taken into account. |
s2b
reviewed
Oct 1, 2024
s2b
reviewed
Oct 1, 2024
s2b
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when errors occur on iterating through the installed view helpers. The generation of the XSDs then break hard with an exception. Currently, this occurs with the TYPO3 extension "schema".
Now, these errors are catched and collected. A calling script can get and display these errors. This way, the generation of XSDs is not cancelled, but proceed without the erroneous view helpers.
This is especially useful for the TYPO3 command "fluid:schema:generate".
Related: #1005