[FEATURE] Support Vendor.Package as namespace name #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #328 before tests will succeed. Will need to be conflict resolved and rebased. |
|
Like the patch, tried to rebase it, but didn't succeed, got quite some unit test failures after a straight conflict resolving. Could you have a look at this, Claus? |
NamelessCoder
force-pushed
the
directnamespace
branch
2 times, most recently
from
f4d061b
to
ea20c2f
Compare
|
Thanks for reviewing / testing, Christian :) This last force-push should fix the issue. The error messages were slightly different and there was a PHP 5.x problem as well. |
Using this format (or simply Package if no vendor name is used for the package) makes ViewHelperResolver look in that namespace + ViewHelpers, for example: ```xml <TYPO3Fluid.Fluid:render partial="Partial" /> ``` Will internally resolve to: ```php \TYPO3Fluid\Fluid\ViewHelpers\RenderViewHelper ``` Without the need to register the namespace. Note that the example uses the native Fluid namespace to demonstrate, although this namespace is always present (unless explicitly removed by a an override).
NamelessCoder
force-pushed
the
directnamespace
branch
from
ea20c2f
to
4bdd92a
Compare
|
Fixed a minor commit message problem (TemplatePaths was mentioned as the place to change ViewHelper namespaces, I guess I was thinking about something else while writing that). |
mbrodala
approved these changes
Jul 11, 2018
albe
approved these changes
Aug 23, 2018
|
I'd say yes since there is no rule that a namespace must use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this format (or simply Package if no vendor name is
used for the package) makes ViewHelperResolver look in
that namespace + ViewHelpers, for example:
Will internally resolve to:
Without the need to register the namespace. Note that the
example uses the native Fluid namespace to demonstrate,
although this namespace is always present (unless explicitly
removed by a an override).