Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/emit dts #21

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Feat/emit dts #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3790df
feat: emit .d.ts files
kuroidoruido Sep 17, 2024
3b584e7
fix: generated package.json
kuroidoruido Sep 17, 2024
f0b5209
ci: add PR pipeline
kuroidoruido Sep 17, 2024
6d76289
chore: prettier setup
kuroidoruido Sep 17, 2024
ccd0757
chore: fix prettier issues
kuroidoruido Sep 17, 2024
c8a9e87
refactor: more TypeScript way of doing some things
kuroidoruido Sep 17, 2024
d83e4d7
chore: enforce formatting with eslint
kuroidoruido Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
name: PR
on:
pull_request:

jobs:
pr:
timeout-minutes: 60
runs-on: ubuntu-latest
permissions: write-all
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
- name: Setup variables
id: setup
run: |
cat package.json | grep "version" | sed 's/ "version": "\([^"]*\)",/\1/' >> .tmp-version
echo "VERSION=$(cat .tmp-version)" >> "$GITHUB_OUTPUT"
cat .tmp-version
rm .tmp-version
- name: Install dependencies
run: npm ci
- name: Code style
run: |
npm run lint
npm run prettier
- name: Unit Tests
run: npm test
# TODO: setup Playwright tests or remove this
# - name: Install Playwright Browsers
# run: npx playwright install --with-deps
# - name: Run Playwright tests
# run: npm run e2e
# - name: Keep test report
# uses: actions/upload-artifact@v4
# if: always()
# with:
# name: playwright-report
# path: playwright-report/
# retention-days: 30
- name: Create release
if: always()
env:
VERSION: ${{ steps.setup.outputs.VERSION }}
run: |
npm run build
npm pack
- name: Keep release archive
uses: actions/upload-artifact@v4
if: always()
env:
VERSION: ${{ steps.setup.outputs.VERSION }}
with:
name: talk-control-revealjs-extensions-${{env.VERSION}}
path: talk-control-revealjs-extensions-${{env.VERSION}}.tgz
retention-days: 30
3 changes: 3 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.github
dist
node_modules
1 change: 0 additions & 1 deletion .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"trailingComma": "all",
"tabs": true,
"tabWidth": 4,
"semi": true,
"bracketSameLine": true,
Expand Down
4 changes: 4 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
2 changes: 1 addition & 1 deletion demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
Expand Down
Loading