Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting started example #2761

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix getting started example #2761

wants to merge 5 commits into from

Conversation

unDemian
Copy link

The example presented in the Getting Started section of Start is not working properly.

Issues

  1. There is no element with root id which means the app will not start properly.
SCR-20241114-upjf
  1. updateCount requires a { data, ... } object
  2. Apparently the default method for createServerFn is not GET so it should be provided.

@adgang adgang mentioned this pull request Nov 15, 2024
Closed
@adgang
Copy link

adgang commented Nov 15, 2024

The updateCount method type should be POST, no?

@unDemian
Copy link
Author

unDemian commented Nov 17, 2024 •
edited
Loading

The updateCount method type should be POST, no?

Indeed, updated.

  1. There is no element with root id which means the app will not start properly.

Has been fixed by #2757

  1. updateCount requires a { data, ... } object

Has been fixed by #2775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unDemian @adgang