Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rerender test #2796

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mta-trackunit
Copy link
Contributor

This changes so Tanstack router will support rerenders in tests using the renderHooks from testing library.

import { renderHook } from '@testing-library/react'

We heavily depend on the rerender tests to ensure no state changes are done in hooks, to avoid infinite rerender issues that are really hard to find and fix, so would really appriciate getting this issue fixed, I hope this solution is sufficient.

Copy link

nx-cloud bot commented Nov 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e824ccd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:unit,test:e2e,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitz

More templates

@tanstack/arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/arktype-adapter@2796

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2796

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2796

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2796

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2796

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2796

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2796

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2796

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2796

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2796

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2796

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2796

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2796

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2796

@tanstack/valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-adapter@2796

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2796

@tanstack/zod-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-adapter@2796

commit: e824ccd

@mta-trackunit mta-trackunit changed the title Allow rerender Allow rerender test Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant