Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use absolute url for og:image tag #270

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: use absolute url for og:image tag #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca79d56
fix: use absolute url for og:image tag
Balastrong Sep 10, 2024
dd7577f
fix: open graph tags are under property instead of name
Balastrong Sep 11, 2024
98d6e05
refactor: use vercel env to read site url
Balastrong Sep 11, 2024
d97690d
fix: try again with hardcoded url
Balastrong Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/routes/__root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const Route = createRootRouteWithContext<{
...seo({
title: 'TanStack | High Quality Open-Source Software for Web Developers',
description: `Headless, type-safe, powerful utilities for complex workflows like Data Management, Data Visualization, Charts, Tables, and UI Components.`,
image: ogImage,
image: `https://tanstack.com${ogImage}`,
keywords:
'tanstack,react,reactjs,react query,react table,open source,open source software,oss,software',
}),
Expand Down
8 changes: 4 additions & 4 deletions app/utils/seo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ export const seo = ({
{ name: 'twitter:description', content: description },
{ name: 'twitter:creator', content: '@tannerlinsley' },
{ name: 'twitter:site', content: '@tannerlinsley' },
{ name: 'og:type', content: 'website' },
{ name: 'og:title', content: title },
{ name: 'og:description', content: description },
{ property: 'og:type', content: 'website' },
{ property: 'og:title', content: title },
{ property: 'og:description', content: description },
...(image
? [
{ name: 'twitter:image', content: image },
{ name: 'twitter:card', content: 'summary_large_image' },
{ name: 'og:image', content: image },
{ property: 'og:image', content: image },
]
: []),
]
Expand Down
Loading