-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features needed by patch
library
#3
Conversation
Use `mappend` to support versions of base that doen't have Semigroup.
Is there anything else that needs to happen here? |
Just checking in again - is there anything else you need from me for this? |
@Taneb Anything else you need from me here? |
@Taneb Anything else necessary to get this merged? |
Having thought it over for a while, I'm not happy with the splitting of the copyright for this library. Either can you transfer me the copyright, or I can ask someone who hasn't seen this PR to implement those particular instances from scratch. |
It's not my copyright to transfer. I can ping someone from Obsidian but I think it would be faster to ask someone to cleanroom it. |
Ryan Trinkle (Partner, Obsidian Systems) consented to this: Taneb#3 (comment)
Okay @Taneb, how's this? |
Thanks heaps! |
I'll get this released ASAP |
And released! https://hackage.haskell.org/package/groups-0.5 |
See also: reflex-frp/patch#4
This PR:
Adds
(~~)
as a group subtraction operator, as it was inpatch
'sGroup
class. It isinfixl 7
based on the discussion inUse Group from elsewhere reflex-frp/patch#4 .
Adds instances for every type present in
base
. Instances forMonoidalMap
are not ported across, becausemonoidal-containers
pulls in
lens
. If this PR is accepted, I will PRmonoidal-containers
to move those instances.Adds a few obvious
Cyclic
instances.Note: To write instances for
(:*:)
and(:.:)
, I had to turn on-XTypeOperators
. This means that we're no longer pure Haskell98. Thecabal documentation has been updated to reflect this. I wrote out the
instances for
Const
andIdentity
by hand to avoid turning on-XStandaloneDeriving
and-XGeneralizedNewtypeDeriving
.