Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add missing case for vector:normalize() #23

Merged
merged 1 commit into from
Feb 7, 2024
Merged

tests: add missing case for vector:normalize() #23

merged 1 commit into from
Feb 7, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 7, 2024

This PR adds a test case covering this line

Lua/src/math/vector.lua

Line 124 in b48e105

return vector.make(0, #self) -- zero vector if input has length zero

@vil02 vil02 marked this pull request as ready for review February 7, 2024 18:20
appgurueu
appgurueu approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@appgurueu appgurueu merged commit c026a97 into TheAlgorithms:main Feb 7, 2024
3 checks passed
@vil02 vil02 deleted the add_missing_test_case_vector branch February 7, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @appgurueu