Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of shadcn, fixes #309 #330

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Pin version of shadcn, fixes #309 #330

merged 1 commit into from
Oct 22, 2024

Conversation

JCB-K
Copy link
Contributor

@JCB-K JCB-K commented Oct 22, 2024

The latest version of the UI package does not include the CLI anymore, it's published under shadcn now - this PR fixes that by pinning the version to 0.8.0, the latest previous version that works.

It would be nice to start using the new CLI, but it's incompatible with the current setup inside NX: it expects package.json and components.json to be defined within the same directory. I think the better approach would be to implement a NX-specific version of the add command instead of using the upstream CLI - it's not particularly complex.

Copy link

nx-cloud bot commented Oct 22, 2024

@TriPSs TriPSs merged commit 9ea43e9 into TriPSs:master Oct 22, 2024
6 checks passed
@JCB-K JCB-K deleted the fix-309 branch October 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants