Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sif develop #133

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Sif develop #133

wants to merge 26 commits into from

Conversation

zhenglecheng
Copy link

Update SIF algorithm

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2021

This pull request introduces 9 alerts when merging 52c60d1 into d4ec947 - view on LGTM.com

new alerts:

  • 5 for Unused local variable
  • 2 for Unused import
  • 2 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2021

This pull request introduces 9 alerts when merging 35fd6ac into 36459f2 - view on LGTM.com

new alerts:

  • 5 for Unused local variable
  • 2 for Unused import
  • 2 for Variable defined multiple times

Copy link

@RahulVadisetty91 RahulVadisetty91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

tf.placeholder has been deprecated in TensorFlow 2.x and needs to be replaced with tf.function or tf.data.Dataset.

Change to: Use tf.function or tf.data.Dataset for inputs. Here a simplified example:

input_index_placeholder = tf.keras.Input(shape=(self.time_steps, 1), dtype=tf.int32, name='input_index')
labels_index_placeholder = tf.keras.Input(shape=(1,), dtype=tf.int32, name='labels_index')
ts_placeholder = tf.keras.Input(shape=(self.y_dim,), dtype=tf.float32, name='input_ts')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants