Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert self intersection behavior: boolean-disjoint #2741

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pm0u
Copy link

@pm0u pm0u commented Oct 29, 2024

Purpose: Bug fix

Partially Addresses:
#2728
#2722

boolean-disjoint

  • Sets ignoreSelfIntersection option to default to true
  • Adds minimal types to geojson in test files to correct TS errors
  • Adds a self intersecting polygon to test cases
  • Updates test cases for expected values based on the flip of "default"
  • Adds test cases for the self intersecting polygon

@pm0u pm0u changed the title Revert self intersection behavior Revert self intersection behavior: boolean-disjoint Oct 30, 2024
@pm0u pm0u marked this pull request as ready for review October 30, 2024 13:38
@pm0u
Copy link
Author

pm0u commented Oct 30, 2024

moving this back to draft as I think it would be best to update this PR after changes in #2742

I think we should determine if we want dependent packages to just rely on the default or to be explicit about a setting (meaning - default to undefined if unprovided which would lead to true OR default to true if unset by the args).

@pm0u pm0u marked this pull request as draft October 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant