Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My update/improvements wrt. build setup, local project setup, type descriptor improvements, additional getters #4

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

sailingKieler
Copy link
Member

@Lotes FYI

…erTy', 'isStruct', 'isVectorTy' in DerivedTypes{.h,.cpp}, added missing declarations in 'llvm-bindings.d.ts'
…ctorType', mainly for having them in the typescript definition

* without these some of Typescript type definitions result in identical types and Typescripts type dispatch via the type guards doesn't work as expected
…ditional constructor allowing to instantiate 'DataLayout' based on the existing 'Module'

added corresponding tests
@sailingKieler sailingKieler requested a review from Lotes July 8, 2024 11:10
Copy link
Collaborator

@Lotes Lotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The inheritance issue is mentioned here.

@sailingKieler sailingKieler merged commit 2993d11 into master Jul 8, 2024
42 checks passed
@sailingKieler sailingKieler deleted the cs/master branch July 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants