Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP-> feat(angular): add angular wrapper #763

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ls-infra
Copy link
Contributor

add the MonacoAngularWrapperComponent as the equivalent to packages/wrapper-react/src/index.tsx
so that the Angular devs can refer this to do two ways data binding (load from API and save back to API ,which is the typical use of the editor )
aslo by passing the wrapperConfig into the wrapper to make it language agnostic to increase reusability

but need some help for this run time exception atm
image

thank you very much

@ls-infra
Copy link
Contributor Author

this wrapper enhances and relates to #759 which changes the component to standalone to make it more reusable and configurable .

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ls-infra thank you. Some small remarks. Regarding the error you saw, I have to test this. Is the dom element (the htmlContainer) defined?

verify/angular/src/app/app.component.ts Outdated Show resolved Hide resolved
verify/angular/src/monaco-angular-wrapper.component.ts Outdated Show resolved Hide resolved
@kaisalmen
Copy link
Collaborator

kaisalmen commented Oct 11, 2024

Yes, the div element with id "monaco-editor-root" is no longer set. This causes the problem

Btw, I switched to the esbuild based system in the angular example, because the workers where no longer working with the custom webpack config. It was able to fix it in the independent webpack example, but that does not work in the angular context.

Due to esbuild/vite build currently some resources from monaco-vscode-api can't be loaded. @CGNonofr FYI, I hoped your existing vite plugin can help here, but the problem origin seems to be different or I need an asset config? I am not super familiar with Angular configuration. If someone can tell me how I can influence/change the vite config in Angular 18 I will be very happy. esbuild plugins can be used.
image

@ls-infra
Copy link
Contributor Author

image @kaisalmen , i just finished the change , still some error , but looks like it is working , thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants