Bug: Certain errors cause bags to be created and uploaded anyways

[zoidy]

Is there an existing issue for this?

• I have searched the existing issues

Description of the bug

The ReBACH specification states that the bag creation process should be atomic (all steps must succeed or else the bag creation process should error out for that item). Refer to 4.4.1 steps 6 and 7 of the spec.

When there is an error copying curation files from curation storage, the software currently displays an error however bag creation continues and the incomplete bag is uploaded. Instead, bag creation should fail and should be deleted.

Steps To Reproduce

Pick a dataset to upload. Then,

• Remove read permissions of one or more files in the UAL_RDM folder
• Run ReBACH
• Observe errors in the log after the line :INFO:Log - Copying files to preservation folder.
• Note that the bag creation and upload process continues