Fix: bags uploaded despite error (Issue #60) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…removed if bags exist in staging
yhan818
reviewed
Aug 24, 2023
yhan818
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added extra code to return the result of the operations that caused the execution to continue on error. Previously, no action was taken when there was an error.
Fixes #60
Screenshots or additional context
Note the fixes for this also partially address Issue #61
Testing (if applicable)
Tested using datasets that exhibited an error during copying files (e.g., 16638328 where one of the curation files permissions were set such that they could not be read by the user that was executing ReBACH)