Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert excel files to csv files. Joe's modules #1508

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Convert excel files to csv files. Joe's modules #1508

wants to merge 8 commits into from

Conversation

mnjowe
Copy link
Collaborator

@mnjowe mnjowe commented Nov 7, 2024

Converting all excel files to CSV files. Joe's modules

@mnjowe mnjowe self-assigned this Nov 7, 2024
@joehcollins
Copy link
Collaborator

@mnjowe - i've just deleted some of the old parameter files which are no longer needed and pushed the changes. (sorry didnt mean to use such an uninformative comit name).

Additionally- does this same process need to happen for pregnancy_supervisor.py?

@joehcollins
Copy link
Collaborator

@EvaJanouskova - have requested your review of this as the updates for the contraception parameter files are also in this branch.

@mnjowe
Copy link
Collaborator Author

mnjowe commented Nov 8, 2024

@mnjowe - i've just deleted some of the old parameter files which are no longer needed and pushed the changes. (sorry didnt mean to use such an uninformative comit name).

Additionally- does this same process need to happen for pregnancy_supervisor.py?

Absolutely right Joe. That Excel file needs to be converted using same method. Can you also remind me any of your modules you feel are using excel files but not included in this PR?

@mnjowe
convert Excel to csv file(s), change from read_excel to read_csv_file…
3acf7f6 
…s for newly created csv file(s)
@mnjowe
Merge remote-tracking branch 'origin/mnjowe/convert_excel_files_to_cs…
831c5f6 
…v_Joe_modules' into mnjowe/convert_excel_files_to_csv_Joe_modules
joehcollins
joehcollins approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@joehcollins joehcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @mnjowe - this looks all good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehcollins joehcollins joehcollins approved these changes

@tbhallett tbhallett Awaiting requested review from tbhallett

@EvaJanouskova EvaJanouskova Awaiting requested review from EvaJanouskova

Assignees

@mnjowe mnjowe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnjowe @joehcollins