Add GetPage<TPage> and AddPageFactory<TPage, TPageFactory> #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliotJones
reviewed
Nov 18, 2023
| $"{typeof(IPdfTokenScanner)}, {typeof(IResourceStore)}, {typeof(ILookupFilterProvider)}, {typeof(IPageContentParser)}, {typeof(ParsingOptions)}."); | ||
| } | ||
|
|
||
| var instance = constructor.Invoke(new object[] |
There was a problem hiding this comment.
Use of reflection may be problematic if we look to support AOT builds in future but will do for now.
There was a problem hiding this comment.
it will definitely be a problem as methods using reflection might be trimmed out.
I have started working on .Net 8 AOT support, here is an example of fix:
BobLd@79f4103#diff-b302975a4cc11925011fc218ef0f880d103758850dd9eddc73b5f61968335b8cR208-R209
I will work on on adding full AOT support soon, happy for someone else to work on it / help though
EliotJones
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XObjectFactoryto public APIContentStreamProcessormain logic intoBaseStreamProcessorPageFactorymain logic intoBasePageFactoryGetPage<TPage>andAddPageFactory<TPage, TPageFactory>methodsTransformationMatrix.Transform(double, double)This is the final refactoring in order to implement page rendering as images. These are 5 commits so that it's easier to review.
Any feedback welcome