Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes are done #322

Closed
wants to merge 1 commit into from
Closed

changes are done #322

wants to merge 1 commit into from

Conversation

akshaysoni10
Copy link

Related Issue

  • Issue of Locations names.

Closes: #292

Describe the changes you've made

I added checkbox property on locations names.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated
original screenshot updated screenshot

Code of Conduct

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibey ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:00pm

@vercel
Copy link

vercel bot commented Jun 22, 2023

@akshaysoni10 is attempting to deploy a commit to the unikonf-vibey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a pull request for vibey!

We appreciate your contribution and are excited to review your changes. If you have any questions or need additional information, please don't hesitate to let us know. We look forward to working with you to improve vibey. Thanks again for your support!

If you want to keep contributing to open source and want to do it with a supportive and inclusive community, consider joining UniKonf. We help and encourage each other to make regular contributions to open source projects. If you have any questions, do not hesitate to ask. We look forward to having you as part of our community!

Copy link
Collaborator

@Deepu178 Deepu178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshaysoni10 I want the checkbox to be there but actually not the check box icon there just the name of the city.

@akshaysoni10
Copy link
Author

@Deepu178 Can you show me any screenshot of that so I can clearly understand.

@Deepu178 Deepu178 closed this Jul 8, 2023
@Deepu178
Copy link
Collaborator

Deepu178 commented Jul 8, 2023

Thanks for raising pr but we have changed our plan for filtering options that's why I have to close this. I would suggest you to look into other issues which needed your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Make locations name under filter button more beautiful.]
2 participants