Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i16 Process subsets #862

Merged
merged 10 commits into from
Apr 24, 2024
Merged

Conversation

bkiahstroud
Copy link
Collaborator

@bkiahstroud bkiahstroud commented Apr 16, 2024

various minor improvements

4887565

log if file already exists in target dir

5e04b54

add method to audit duplicate XML files

e43449e

Specifically, we're auditing whether their content differs from each
other or not. If not, we aren't concerned with handling the duplicates
further, but if the content does differ, we need to figure out how

if XML file doesn't exist, capture and log error

2d09bca

add methods to delete/recreate subsets

b5ff103

run migrations on test db schema

269a593

@bkiahstroud bkiahstroud requested a review from afred April 16, 2024 01:12
@bkiahstroud bkiahstroud changed the title i16 MissingInstantiationsLocator improvements i16 Audit duplicate XML files + minor improvements Apr 17, 2024
@bkiahstroud bkiahstroud changed the title i16 Audit duplicate XML files + minor improvements i16 Process subsets Apr 23, 2024
Specifically, we're auditing whether their content differs from each
other or not. If not, we aren't concerned with handling the duplicates
further, but if the content does differ, we need to figure out how
@bkiahstroud bkiahstroud force-pushed the i16-missing-instantiations-locator-improvements branch from 269a593 to 26bacb7 Compare April 23, 2024 20:38
aprilrieger
aprilrieger previously approved these changes Apr 23, 2024
@bkiahstroud bkiahstroud force-pushed the i16-missing-instantiations-locator-improvements branch from 09be0d8 to 531f451 Compare April 24, 2024 15:40
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 9a1cea3 into develop Apr 24, 2024
6 checks passed
@afred afred deleted the i16-missing-instantiations-locator-improvements branch April 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants