Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a non-normative use cases section #142

Merged
merged 7 commits into from
Mar 17, 2024
Merged

Add a non-normative use cases section #142

merged 7 commits into from
Mar 17, 2024

Conversation

blu25
Copy link
Collaborator

@blu25 blu25 commented Jan 24, 2024

This adds a new "use cases" subsection to the "Fenced frame configs" section. This outlines 2 use cases (ad rendering + personalized payment button) and how it relates to the different ways to build a fenced frame config. They also go into privacy stories for both use cases.

I had also considered putting this in the main "Introduction" section, but decided it was both better to keep that section brief and to put this in a place where the concept of a "fenced frame config" had already been introduced.


Preview | Diff

@blu25 blu25 marked this pull request as ready for review January 24, 2024 20:40
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, please fix the wrapping if the suggestions break that. (This seems to be a shortcoming of GitHub code suggestions).

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
blu25 and others added 5 commits February 12, 2024 12:48
Co-authored-by: Dominic Farolino <[email protected]>
Co-authored-by: Dominic Farolino <[email protected]>
Co-authored-by: Dominic Farolino <[email protected]>
Co-authored-by: Dominic Farolino <[email protected]>
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@domfarolino domfarolino merged commit 5b3cdb6 into master Mar 17, 2024
2 checks passed
@domfarolino domfarolino deleted the liam-use-cases branch March 17, 2024 18:35
github-actions bot added a commit that referenced this pull request Mar 17, 2024
SHA: 5b3cdb6
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants