Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec partition nonce functionality #149

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Spec partition nonce functionality #149

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eed0df0
add credentialless iframe spec
Apr 9, 2024
9b9be96
iframe credentialless section
Apr 11, 2024
2969e29
add skeleton
Apr 25, 2024
1f35fdb
address comments
Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,19 @@ spec: url; for:/; type: dfn; text: url
"deliveredBy": [
"https://wicg.io/"
]
},
"iframe-credentialless": {
"authors": [
"Arthur Sonzogni",
"Camille Lamy"
],
"href": "https://wicg.github.io/anonymous-iframe/",
"title": "Iframe credentialless",
"status": "CG-DRAFT",
"publisher": "WICG",
"deliveredBy": [
"https://wicg.io/"
]
}
}
</pre>
Expand Down Expand Up @@ -3291,6 +3304,53 @@ at the expense of some utility.
</wpt>
</div>

<h3 id=credentialless-monkeypatch>Iframe credentialless</h3>

Note: The [[!IFRAME-CREDENTIALLESS]] specification defines a new object, the
[=page credentialless nonce=]. At a high level, the
[=fenced frame config instance/partition nonce=] serves the same purpose as the
[=page credentialless nonce=] (partitioning storage and network), but scoped to each fenced
frame rather than to each credentialless iframe. The
[=fenced frame config instance/partition nonce=] is also used to revoke network access in fenced
frames.

Add the following algorithm:
gtanzer marked this conversation as resolved.
Show resolved Hide resolved

<div algorithm>
To <dfn for="browsing context">compute the effective partition nonce</dfn> given a
boolean |isCredentialless| and [=fenced frame config instance/partition nonce=] or null
|newFencedFrameNonce|:

1. If |credentialless| is true, return |this|'s [=top-level browsing context=]'s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credentialless => isCredentialless

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really change this, since it corresponds to an exposed IDL attribute.
https://wicg.github.io/anonymous-iframe/#spec-window-attribute

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well where are you getting |credentialless| from then? It's not just a global variable is it?

Copy link
Collaborator Author

@gtanzer gtanzer Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a local variable, but I meant it would be weird to call it something else when it corresponds exactly to this preexisting field, and the same name is used throughout the Iframe credentialless spec

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this local variable defined? Sorry I don't think I'm getting it.

Copy link
Collaborator Author

@gtanzer gtanzer Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I misread this. I didn't mean to name the variable isCredentialless above in the declaration. The iframe credentialless spec refers to this kind of variable as credentialless throughout, so it would be inconsistent naming to use isCredentialless here. Changed the declaration back to credentialless to match.

[=page credentialless nonce=].

1. If |newFencedFrameNonce| is not null, return |newFencedFrameNonce|.

1. Let |instance| be |this|'s [=browsing context/fenced frame config instance=].

1. If |instance| is null, return null.

1. Return |instance|'s [=fenced frame config instance/partition nonce=].
</div>

<div algorithm="process a navigate fetch">
Modify the step added to [=process a navigate fetch=] to read:
gtanzer marked this conversation as resolved.
Show resolved Hide resolved

13. Let |partitionNonce| be the result of [=computing the effective partition nonce=] on
|browsingContext| given |credentialless| and |sourceSnapshotParams|'s
[=source snapshot params/target fenced frame config=].
</div>

<div algorithm="initialize the document object">
Modify the step added to [=initialize the document object=] to read:
gtanzer marked this conversation as resolved.
Show resolved Hide resolved

6.9. Let |partitionNonce| be the result of [=computing the effective partition nonce=] on
|browsingContext| given |navigationParams|'s [=credentialless=] and null if
|navigationParams|'s [=navigation params/fenced frame config instance=] is null else
|navigationParams|'s [=navigation params/fenced frame config instance=]'s
[=fenced frame config instance/partition nonce=].
</div>

<h2 id=security-and-privacy>Security & Privacy Considerations</h2>

This material is being upstreamed from our explainer into this specification, and in the meantime
Expand Down
Loading