Spec network revocation mechanism to disable fetches #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
reviewed
Jul 10, 2024
gtanzer
changed the title
|
@domfarolino Is there a way to explicitly mark it draft? I didn't request a review. I'll just add WIP to the title. |
gtanzer
changed the title
|
@domfarolino I think the content is "done" now, % resolving some links. But it would be good if you could take a look at it first so I don't resolve links that will be deleted/moved around later. The part I'm least sure about is where to define the extra objects on the user agent. In the fetch spec, it defines the connection pool on the "user agent" which isn't a formal object, so I don't know if I should monkeypatch these definitions near there or just keep them in here. |
blu25
reviewed
Sep 11, 2024
blu25
reviewed
Sep 11, 2024
blu25
reviewed
Sep 11, 2024
blu25
reviewed
Sep 11, 2024
blu25
reviewed
Sep 11, 2024
domfarolino
reviewed
Nov 1, 2024
domfarolino
approved these changes
Nov 4, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 4, 2024
SHA: feb1afd Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff