Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version checker #165

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Add version checker #165

merged 4 commits into from
Oct 7, 2024

Conversation

nnichols
Copy link
Member

@nnichols nnichols commented Oct 7, 2024

Proposed Changes

  • Additions: sealog.version namespace with functions for working with Clojure versions.
  • Updates: sealog.core/when-let+ throws a more specific exception when the bindings vector contains an odd number of forms.
  • Deletions:

Pre-merge Checklist

  • Read and agree to the Contribution Guidelines and Code of Conduct
  • Write new tests for the changed functionality
  • Update CHANGELOG and increment version
  • Update README and relevant documentation

@nnichols nnichols requested a review from a team as a code owner October 7, 2024 16:18
@WallBrewBot WallBrewBot added documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD dependencies Updates to application dependency files test code Updates to the application or library test code source code Updates to the application or library source code tooling Repository tools, CI/CD jobs, automated actions clojure Clojure source code clojurescript ClojureScript source code labels Oct 7, 2024
@nnichols nnichols merged commit 70f2387 into master Oct 7, 2024
15 checks passed
@nnichols nnichols deleted the add-version-checker branch October 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dareknotderek Dareknotderek Awaiting requested review from Dareknotderek Dareknotderek is a code owner automatically assigned from Wall-Brew-Co/wall-brew-developers

Assignees
No one assigned
Labels
clojure Clojure source code clojurescript ClojureScript source code dependencies Updates to application dependency files documentation Improvements or additions to documentation dotfiles Configuration files for developer tools and CI/CD source code Updates to the application or library source code test code Updates to the application or library test code tooling Repository tools, CI/CD jobs, automated actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnichols @WallBrewBot