Use SSLKEYLOGFILE env to enable logging SSL keys in libwebrtc / borin… #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gssl For debugging, it's sometimes useful to be able to decrypt captured TLS traffic. By setting SSLKEYLOGFILE env variable, it's possible to log secrets to a file, which can then be used for decryption. But libwebrtc uses a separate TLS implementation, boringssl, which does not support it by default. Add key logging in libwebrtc if the env is set.
|
Hi @philn , Can you look at this PR to see if it can be maintained? and please comment about coding style and IO api usage. Thank you very much! |
|
This is directly copy/pasted from https://boringssl.googlesource.com/boringssl/+/refs/heads/master/tool/client.cc so please give credit to the original author :) |
|
Have you tried mitmproxy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gssl
For debugging, it's sometimes useful to be able to decrypt captured TLS traffic. By setting SSLKEYLOGFILE env variable, it's possible to log secrets to a file, which can then be used for decryption.
But libwebrtc uses a separate TLS implementation, boringssl, which does not support it by default.
Add key logging in libwebrtc if the env is set.