-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WAS-580/WAS-575] - Upgraded strimzi Azure #52
Conversation
devopswolfram
commented
Aug 10, 2023
•
edited
Loading
edited
- Upgraded strimzi version from 0.23 to 0.29
- Upgraded kafka version from 2.8.0 to 3.0.0
- Upgraded kubernetes version 1.24 to 1.25
- Removed old ingress controller and replaced with helm
This PR is missing a github actions pipeline to validate the PR builds successfully (you want verify / test deployment - you may consider using kind) |
@@ -2,10 +2,9 @@ apiVersion: kafka.strimzi.io/v1beta2 | |||
kind: Kafka | |||
metadata: | |||
name: kafka-persistent | |||
namespace: kafka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you aware of the repercussion(s) removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, fixed.
storage: | ||
type: jbod | ||
volumes: | ||
- id: 0 | ||
type: persistent-claim | ||
size: 10Gi | ||
deleteClaim: false | ||
class: was-azurefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which storageclass are you planning to use? What if there is no default? (The deployment will fail)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is always a default sc in this deployment. I removed it for some reason, will check.
@@ -118,7 +116,7 @@ spec: | |||
resources: | |||
limits: | |||
cpu: 1000m | |||
memory: 384Mi | |||
memory: 2Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per strimzi source code / recommendation this value is memory: 384Mi
- why has it been changed to 2Gi
? how was this increased value chosen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason kafka-persistent-kafka pods are exited with OOMKilled when initializing and it caused failure of the script. I increased the limits to 1Gi, the result was same. So I increased it to 2Gi.
Yes, in default they're 384Mi in the helm chart.
https://github.com/strimzi/strimzi-kafka-operator/blob/0.29.0/helm-charts/helm3/strimzi-kafka-operator/values.yaml#L139-L142
We faced OOMKilled issue when testing kafka.
Increased limits.memory to 2Gi |
…rch/WAS-Kubernetes into cenka/upgrade-strimzi-azure