Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAS-580/WAS-575] - Upgraded strimzi Azure #52

Merged
merged 12 commits into from
Dec 5, 2023

Conversation

devopswolfram
Copy link
Contributor

@devopswolfram devopswolfram commented Aug 10, 2023

  • Upgraded strimzi version from 0.23 to 0.29
  • Upgraded kafka version from 2.8.0 to 3.0.0
  • Upgraded kubernetes version 1.24 to 1.25
  • Removed old ingress controller and replaced with helm

@ghost
Copy link

ghost commented Aug 16, 2023

This PR is missing a github actions pipeline to validate the PR builds successfully (you want verify / test deployment - you may consider using kind)

@@ -2,10 +2,9 @@ apiVersion: kafka.strimzi.io/v1beta2
kind: Kafka
metadata:
name: kafka-persistent
namespace: kafka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you aware of the repercussion(s) removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, fixed.

storage:
type: jbod
volumes:
- id: 0
type: persistent-claim
size: 10Gi
deleteClaim: false
class: was-azurefile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which storageclass are you planning to use? What if there is no default? (The deployment will fail)

Copy link
Contributor Author

@devopswolfram devopswolfram Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is always a default sc in this deployment. I removed it for some reason, will check.

@@ -118,7 +116,7 @@ spec:
resources:
limits:
cpu: 1000m
memory: 384Mi
memory: 2Gi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per strimzi source code / recommendation this value is memory: 384Mi - why has it been changed to 2Gi ? how was this increased value chosen?

Copy link
Contributor Author

@devopswolfram devopswolfram Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason kafka-persistent-kafka pods are exited with OOMKilled when initializing and it caused failure of the script. I increased the limits to 1Gi, the result was same. So I increased it to 2Gi.

Yes, in default they're 384Mi in the helm chart.
https://github.com/strimzi/strimzi-kafka-operator/blob/0.29.0/helm-charts/helm3/strimzi-kafka-operator/values.yaml#L139-L142

@devopswolfram
Copy link
Contributor Author

We faced OOMKilled issue when testing kafka.

[(⎈|WAS-aks:kafka)]$ k top pods
NAME                                       CPU(cores)   MEMORY(bytes)   
kafka-bridge-d9958bc9c-ttcl7               113m         208Mi           
kafka-persistent-kafka-0                   404m         706Mi           
kafka-persistent-kafka-1                   736m         870Mi           
kafka-persistent-kafka-2                   385m         716Mi           
kafka-persistent-zookeeper-0               29m          475Mi           
kafka-persistent-zookeeper-1               130m         597Mi           
kafka-persistent-zookeeper-2               57m          462Mi           
strimzi-cluster-operator-d5b5c5bcb-4ntfq   123m         497Mi 

Increased limits.memory to 2Gi

@devopswolfram devopswolfram merged commit d5765a6 into master Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants