Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Escaping, Strict Check, and PHPCS Issues in Multiple Files #340

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function jobswp_archive_header( $before = '', $after = '', $jobscnt = 0, $catego
$jobscnt = sprintf( _n( '%d job', '%d jobs', $jobscnt, 'jobswp' ), $jobscnt );
}

$link .= " <span class='posts-count'>($orig_jobscnt)</span> $after";
$link .= " <span class='posts-count'>($orig_jobscnt)</span> $after";
$output .= $link;
$output .= '<div class="grid_2 omega jobs-count">';

Expand Down Expand Up @@ -192,7 +192,7 @@ function jobswp_field_value( $field, $option_value = '' ) {
if ( $val ) {
if ( in_array( $field, array( 'category', 'howtoapply_method', 'jobtype' ) ) )
return selected( $val, $option_value, false );
elseif ( 'job_description' == $field )
elseif ( 'job_description' === $field )
return $val;
else
return "value='$val'";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
if ( ! $category )
$category = array_pop( get_the_terms( get_the_ID(), 'job_category') );

$link = '';
$link = '';
$link .= '<a href="' . esc_attr( get_term_link( $category, 'job_category' ) ) . '" ';
$link .= 'title="'. esc_attr( sprintf( __( 'View all jobs filed under %s', 'jobswp' ), $category->name ) ) . '"';
$link .= '>';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
$val = jobswp_get_job_meta( get_the_ID(), $fname );
if ( $val ) :
?>
<dl class="job-<?php echo $fname; ?>">
<dt><?php echo $flabel; ?></dt>
<dd><?php echo $val; ?></dd>
<dl class="job-<?php echo esc_attr( $fname ); ?>">
<dt><?php echo esc_html( $flabel ); ?></dt>
<dd><?php echo esc_html( $val ); ?></dd>
</dl>
<?php
endif;
Expand Down