Delete a suggestion from TM #357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
requested changes
Aug 20, 2024
...ublic_html/wp-content/plugins/wporg-gp-translation-suggestions/js/translation-suggestions.js
Show resolved
Hide resolved
.../wp-content/plugins/wporg-gp-translation-suggestions/inc/class-translation-memory-client.php
Outdated
Show resolved
Hide resolved
akirk
reviewed
Aug 21, 2024
.../wp-content/plugins/wporg-gp-translation-suggestions/inc/class-translation-memory-client.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a button, only for the GTE, in the suggestions from the translation memory, to be able to delete a suggestion from the translation memory. This button is added only if the similarity between the current original and the suggestion from the translation memory is 100%.
Button visible only for a Galician GTE in a Galician string.
If the user is not a GTE, she won't have this button. Image for a user who isn't a Spanish GTE in a Spanish string.
This PR needs to implement the
deletemethod for theTranslation_Memory_Clientclass, but first we need a new method in the https://translate.wordpress.com/api/tm/ API.The AJAX request implements the
POSTmethod, instead theDELETEmethod, because we need to send some data in the request, and theDELETEmethod doesn't allow it.