Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce MPT support (XLS-33d): #5143

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
+6,664 −1,015

Address reviewer feedback

ea887bf
Select commit
Loading
Failed to load commit list.
Open

Introduce MPT support (XLS-33d): #5143

Address reviewer feedback
ea887bf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

76.2% (target 60.0%)

View this Pull Request on Codecov

76.2% (target 60.0%)

Details

Codecov Report

Attention: Patch coverage is 83.57083% with 196 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (1fbf8da) to head (ea887bf).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/protocol/STAmount.cpp 79.9% 34 Missing ⚠️
src/xrpld/rpc/handlers/LedgerEntry.cpp 5.9% 32 Missing ⚠️
src/xrpld/app/tx/detail/InvariantCheck.cpp 65.5% 30 Missing ⚠️
src/xrpld/app/tx/detail/Payment.cpp 86.5% 21 Missing ⚠️
src/libxrpl/basics/MPTAmount.cpp 12.5% 14 Missing ⚠️
src/xrpld/ledger/detail/View.cpp 91.8% 11 Missing ⚠️
src/xrpld/app/tx/detail/MPTokenAuthorize.cpp 92.5% 8 Missing ⚠️
src/libxrpl/protocol/MPTIssue.cpp 62.5% 6 Missing ⚠️
src/libxrpl/protocol/STParsedJSON.cpp 62.5% 6 Missing ⚠️
src/xrpld/app/tx/detail/Clawback.cpp 93.2% 5 Missing ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #5143    +/-   ##
========================================
  Coverage     76.2%   76.2%            
========================================
  Files          760     775    +15     
  Lines        61568   62505   +937     
  Branches      8126    8214    +88     
========================================
+ Hits         46909   47652   +743     
- Misses       14659   14853   +194
Files with missing lines Coverage Δ
include/xrpl/basics/MPTAmount.h 100.0% <100.0%> (ø)
include/xrpl/basics/Number.h 100.0% <100.0%> (ø)
include/xrpl/basics/XRPAmount.h 98.8% <ø> (ø)
include/xrpl/basics/base_uint.h 96.6% <ø> (ø)
include/xrpl/protocol/AmountConversions.h 87.5% <100.0%> (ø)
include/xrpl/protocol/Feature.h 100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h 100.0% <100.0%> (ø)
include/xrpl/protocol/Issue.h 100.0% <100.0%> (ø)
include/xrpl/protocol/MPTIssue.h 100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h 100.0% <ø> (ø)
... and 57 more

... and 7 files with indirect coverage changes

Impacted file tree graph

View more details on Codecov