Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pop with UIView animations #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evandcoleman
Copy link

pop has been deprecated by Facebook. This PR replaces pop animations with standard UIView animations. I also bumped the deployment target to iOS 10 which is when UIView property animations were introduced.

@evandcoleman
Copy link
Author

Fixes #435

@deberle
Copy link

deberle commented Nov 3, 2021

I would love to see this merged!

@VanjaPopovic
Copy link

I would love to see this merged as well!

@wvteijlingen
Copy link

+1 for getting this merged. Will bring us one step closer to supporting SPM :).

@Teglgaard
Copy link

+1 This would make a difference without that dependency!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants